Mellanox / sockperf

Network Benchmarking Utility
Other
585 stars 119 forks source link

issue: 2583763 Add CI for Windows #199

Closed vasily-v-ryabov closed 2 years ago

vasily-v-ryabov commented 2 years ago

Signed-off-by: Vasily Ryabov vryabov@nvidia.com

igor-ivanov commented 2 years ago

how to see windows ci result?

EldarShalev commented 2 years ago

all the errors are the same:

c:\Jenkins\workspace\sockperf-windows\src\os_abstract.h(60,1): error C2220: the following warning is treated as an error [c:\Jenkins\workspace\sockperf-windows\win\project\sockperf.vcxproj]

c:\Jenkins\workspace\sockperf-windows\src\os_abstract.h(60,1): warning C4005: 'PRIu64': macro redefinition [c:\Jenkins\workspace\sockperf-windows\win\project\sockperf.vcxproj]

C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\ucrt\inttypes.h(174): message : see previous definition of 'PRIu64' [c:\Jenkins\workspace\sockperf-windows\win\project\sockperf.vcxproj]

c:\Jenkins\workspace\sockperf-windows\src\os_abstract.h(61,1): warning C4005: 'PRId64': macro redefinition [c:\Jenkins\workspace\sockperf-windows\win\project\sockperf.vcxproj]

C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\ucrt\inttypes.h(117): message : see previous definition of 'PRId64' [c:\Jenkins\workspace\sockperf-windows\win\project\sockperf.vcxproj]

c:\Jenkins\workspace\sockperf-windows\src\message.h(123,1): warning C4311: 'type cast': pointer truncation from 'void *' to 'long' [c:\Jenkins\workspace\sockperf-windows\win\project\sockperf.vcxproj]

c:\Jenkins\workspace\sockperf-windows\src\message.h(123,1): warning C4302: 'type cast': truncation from 'void *' to 'long' [c:\Jenkins\workspace\sockperf-windows\win\project\sockperf.vcxproj]
vasily-v-ryabov commented 2 years ago

@igor-ivanov I'm planning to enable Windows CI for each PR after fixing all compilation issues and merging all to master branch.

EldarShalev commented 2 years ago

@vasily-v-ryabov can you compile with different warning level just to verify compilation succeeds? I'll create a separate PR for fixing warnings error

https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2220?view=msvc-170

EldarShalev commented 2 years ago

@igor-ivanov @vasily-v-ryabov create a PR for this error:

https://github.com/Mellanox/sockperf/pull/201

vasily-v-ryabov commented 2 years ago

With PR #201 the situation changed from

    113 Warning(s)
    11 Error(s)

to

    39 Warning(s)
    11 Error(s)

See build output: http://hpc-master.lab.mtl.com:8080/job/sockperf-windows/2/console

igor-ivanov commented 2 years ago

@vasily-v-ryabov please follow project commit convention as 'issue: 2583763 Add CI for Windows'

swx-jenkins3 commented 2 years ago

Can one of the admins verify this patch?