Issue:4044453:Replace the flask framework with aiohttp in PDR plugin

Mellanox / ufm_sdk_3.0

BSD 3-Clause "New" or "Revised" License

20 stars 21 forks source link

Issue:4044453:Replace the flask framework with aiohttp in PDR plugin #243

Closed vg12345 closed 2 months ago

vg12345 commented 2 months ago

What

Replace the flask framework with aiohttp in PDR plugin

Why ?

#4044453

Testing ?

Automatic tests

Special triggers

Use the following phrases as comments to trigger different runs

bot:retest rerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)
bot:upgrade run additional update tests

vg12345 commented 2 months ago

bot:retest

vg12345 commented 2 months ago

looks fine. do we need the base class as wrapper?

Not necessary but more readable. I decided to define all common, API-specific independent functionality to base class. In addition, we can later move the base class to utils and reuse.

vg12345 commented 2 months ago

bot:retest