search

MelleD / lovelace-expander-card

Expander card for HomeAssistant
Apache License 2.0
56 stars 6 forks source link

title-card-clickable for touch input #187

Closed Caligo82 closed 2 months ago

Caligo82 commented 3 months ago

Is your feature request related to a problem? Please describe. I'm trying to make the "title-card-clickable" work for touch inputs. However it is either not supported or I'm doing it wrong...

Describe the solution you'd like I'd like for the expander card to expand with touch input while a title card is selected and "title-card-clickable" is set to true.

Describe alternatives you've considered Since there's no manual "expand card xy" action I struggle to implement an alternative with a button action.

Additional context It works with mouse clicks. Just not with touch.

github-actions[bot] commented 2 months ago

Release 1.6.0 addresses this.

Caligo82 commented 2 months ago

At least in my config it's not working with 1.6.0 I'm afraid...

MelleD commented 2 months ago

At least in my config it's not working with 1.6.0 I'm afraid...

As always you have to refresh and delete your cache or try it in private ingocnito browser. Without log and info from your console I can say not more.

For iOS App it take 1-2 days till they download the new version. No idea why have the same issue for other cards

Caligo82 commented 2 months ago

Even cleared cache, tried incognito... to no avail. I'm using a picture card for this. Tried a new card as well. No luck there. What logs are you looking for?

MelleD commented 2 months ago

Can you check the browser console which version?

Let me check with picture card maybe there is an issue that the event goes not to the child

EDIT: Maybe I found a better solution let me try this. With iOS touch looks good

Caligo82 commented 2 months ago

It is using the latest version:

image

It also doesn't work with F12 and Mobile View... maybe that helps debugging.

github-actions[bot] commented 2 months ago

Release 1.6.0 addresses this.

Caligo82 commented 2 months ago

It was Release 1.6.1 that fixed it. Other than that: works perfect. Thank you!

Caligo82 commented 2 months ago

Ok, one fun issue remains. It's quite impossible to scroll now. Every touch will activate an expand action. Is this fixable? 😆

MelleD commented 2 months ago

Do you have an example and picture?

Maybe using touchend instead of touchstart https://www.w3schools.com/jsref/event_touchstart.asp

MelleD commented 2 months ago

Yes it not so easy(maybe new bug ticket to track it) but you habe to save the element on touchstart and check if it is the same on touchend. Maybe you can prepare a PR or I have time tomorrow

github-actions[bot] commented 2 months ago

Release 1.6.1 addresses this.