Melledy / LunarCore

A game server reimplementation for a certain turn-based anime game
GNU Affero General Public License v3.0
1.29k stars 276 forks source link

Change duplicate strategy to exclude #69

Closed yuko1101 closed 5 months ago

yuko1101 commented 5 months ago

This pull request changes the duplicate strategy from include to exclude to prevent duplicate files. This is mainly the case with my mod loader, but if the duplicate strategy is set to include, multiple files will be included in the same path in the jar file and will not be decompressed properly. It causes the transformer in gradle to not work and limits the development of the plugin.

Here is my transformer in gradle which does not work with LunarCore jar which built with duplicate strategy INCLUDE. It has the ability to change the access modifier from private or protected to public in an existing JAR file.