MeltanoLabs / Meta

The why, what, and how of MeltanoLabs
MIT License
5 stars 1 forks source link

Meltano supported target-postgres #36

Open pnadolny13 opened 1 year ago

pnadolny13 commented 1 year ago

Development Scope:

Out of scope features mentioned:

pnadolny13 commented 1 year ago

@tayloramurphy I created this to define the scope of development for these new plugins, track status, and decide when its ready to recommend. Can you help fill in the description with the features (specific to this source) we expect the initial release to support? It will help us and users understand what done is and when we're there.

cc @visch @aaronsteers

visch commented 1 year ago

I don't know when we want to make the swap for the default variant the MeltanoLabs variant.

What I can say is what features does transferwise have that we don't have. Note that because transferwise has been used for a lot longer time they have a lot of "longtail" fixes that we just haven't hit yet with the meltanolabs variant. I also haven't been trying to build at feature parity. Maybe we could take the tests from their variant just to verify everything works as expected.

"Important" features missing from meltanolabs variant. I'm not sure these should hold up the swap to default variant recommendation. The target does work today in a lot of use cases:

  1. Activate Version - https://github.com/MeltanoLabs/target-postgres/pull/89 (Done, just needs to get merged)
  2. anyOf - https://github.com/MeltanoLabs/target-postgres/issues/86
  3. SSL - https://github.com/MeltanoLabs/target-postgres/issues/71 (Should be easy)
  4. Append Only - https://github.com/MeltanoLabs/target-postgres/issues/54
  5. Allow Column Alters - https://github.com/MeltanoLabs/target-postgres/issues/2
  6. Parallelism - https://github.com/MeltanoLabs/target-postgres/issues/3 (Should be easy)
  7. Native Batch Support - https://github.com/MeltanoLabs/target-postgres/issues/73

@aaronsteers has prioritized these for me generally in the order from top to botom (Not including anything Parallelism or below)

aaronsteers commented 1 year ago

Thanks, @visch! If SSH (https://github.com/MeltanoLabs/target-postgres/issues/71) becomes difficult, we can push it back. And for anyOf, we can keep the scope there nice and small by focusing on the "nullable" use cases - and not yet handling more complex data type intersections.

With those two notes, I think the above list looks great. Thanks again.

pnadolny13 commented 1 year ago

@aaronsteers @visch this is great! I updated the issue checklist with what I think is the consensus in/out of scope items. Definitely feel free to change them if more stuff comes up thats blocking us recommending this variant.

@aaronsteers @visch I did ^^^ the same thing as I mentioned in https://github.com/MeltanoLabs/Meta/issues/35#issuecomment-1413982770