search

MeltanoLabs / Meta

The why, what, and how of MeltanoLabs
MIT License
5 stars 1 forks source link

Standard Tests Framework Rollout #40

Open kgpayne opened 1 year ago

kgpayne commented 1 year ago

In anticipation of sdk##1171 merging, this issue is to track the rollout of the new tests to commonly used Taps and Targets in MeltanoLabs:

Key:

Taps:

Targets:

aaronsteers commented 1 year ago

@kgpayne - Thanks very much for pre-testing here.

As I noted in the main SDK PR, one thing I wanted to check was to confirm that the old and new test methods both still work. I added back the legacy test with a test_sdk_legacy.py test file name on PR. Looking at the tap-github and tap-stackexchange, it looks like the old method is still in place (at least as of now). Safe to assume we expect legacy tests to keep working at the same time as we are lighting up the new test methods?

edgarrmondragon commented 1 year ago

Safe to assume we expect legacy tests to keep working at the same time as we are lighting up the new test methods?

Might be worth setting a deprecation timeline for the legacy tests. I've ported a docs reorganization from https://github.com/meltano/sdk/pull/1294 into https://github.com/meltano/sdk/pull/1353 that includes a deprecation page: https://meltano-sdk--1353.org.readthedocs.build/en/1353/development/deprecation.html

aaronsteers commented 1 year ago

@edgarrmondragon - Good point. I think in v1.0 we should remove them. I'll log I've logged this as an issue for follow-up as part of the 1.0 milestone.