MeltanoLabs / Meta

The why, what, and how of MeltanoLabs
MIT License
5 stars 1 forks source link

docs: standard for building new connector #49

Closed pnadolny13 closed 1 year ago

pnadolny13 commented 1 year ago

We should document the minimum standard we have for creating a new connector. This can act as a check list for us to know that a connector has completed initial development and should be made available to the community. It also acts as a way to communicate with external contributors or contractors what the expectation and best practices are for creating a new connector.

In https://github.com/MeltanoLabs/Meta/issues/37#issuecomment-1402373597 I created a list of common checklist steps, this could be a good starting place.

Some other best practices that have been mentioned are:

@kgpayne @edgarrmondragon @tayloramurphy let me know what you think of these and if you have more. We can add them to the README or a contributors guide when we're ready.

tayloramurphy commented 1 year ago

@pnadolny13 this is a great start - let's just get a PR up and ready, perhaps within MeltanoLabs?

The other item(s) I would add is:

edgarrmondragon commented 1 year ago

tests pass in CI

@pnadolny13 Should probably clarify this means integration tests