search

MeltanoLabs / Singer-Working-Group

Working group for ongoing development and iteration of the Singer Spec, the de-facto protocol for open source data connectors. Please use "Issues" to create discussion items - or use "Discussions" for general questions.
Apache License 2.0
13 stars 4 forks source link

snake case optional for all Uppercase #34

Closed mkoenings closed 1 year ago

mkoenings commented 1 year ago

I work with Snowflake databases, where all tables, schemas etc are Uppercase. This leads to funny names when loading the data straight into mssql, because all names get "snakecased" so from ABC we get a_b_c. This happens in the conform_name function in singer_sdk/sinks/sql.py , which is applied to all names. Can we change that so its optional ? Alternatively, the snakecase function should ignore all uppercase names.

tayloramurphy commented 1 year ago

@mkoenings this is more appropriate for the https://github.com/meltano/sdk/ repo. Can you open an issue there if this is still an issue for you?