MeltanoLabs / tap-gitlab

Singer.io Tap for extracting data from Gitlab's API
GNU Affero General Public License v3.0
11 stars 29 forks source link

feat: enable fetching retried jobs #107

Closed a-meynard closed 5 days ago

a-meynard commented 6 days ago

fixes https://github.com/MeltanoLabs/tap-gitlab/issues/86

reimplement https://github.com/MeltanoLabs/tap-gitlab/pull/87 to resolve conflicts

sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

a-meynard commented 6 days ago

Hello @edgarrmondragon 👋

Here is a PR that resolve conflicts that previous one had. I merged on legacy-stable as this is the default branch. Tell me if I should merge on main or something else :)

There is also one job on the CI that does not work, probably due to a missing secret. Is there something I should configure on my end ?

Thank you very much !

edgarrmondragon commented 5 days ago

There is also one job on the CI that does not work, probably due to a missing secret. Is there something I should configure on my end ?

That's safe to ignore, and shouldn't even run on PRs from forks anyway 😅

edgarrmondragon commented 5 days ago

Thanks @a-meynard!