search

MeltanoLabs / tap-gitlab

Singer.io Tap for extracting data from Gitlab's API
GNU Affero General Public License v3.0
8 stars 25 forks source link

Remove API version from GitLab extractor API URL #17

Closed pnadolny13 closed 2 years ago

pnadolny13 commented 2 years ago

In GitLab by @gtsiolis on Nov 1, 2019, 12:05

Problem

GitLab has removed API v3 support in GitLab 11.0 and future API versions that will also include GraphQL support will be based on the same version for compatibility reasons.

This allows for a stable API endpoint, but also means new features can be added to the API in the same version number.

  1. This means that including the API version in the GitLab extractor configuration is redundant.
  2. Requiring the base URL is also common for GitLab when adding a Kubernetes cluster.

Proposal

Let's drop the API version altogether from the API URL within the GitLab extractor configuration.

pnadolny13 commented 2 years ago

In GitLab by @gtsiolis on Nov 1, 2019, 12:19

Feel free to move to meltano/tap-gitlab if needed or preferrable.

pnadolny13 commented 2 years ago

In GitLab by @iroussos on Nov 1, 2019, 13:15

moved from meltano#1237

pnadolny13 commented 2 years ago

In GitLab by @iroussos on Nov 1, 2019, 13:15

assigned to @iroussos

pnadolny13 commented 2 years ago

In GitLab by @iroussos on Nov 1, 2019, 13:16

Moved issue to the tap-gitlab project so that we can address it in one of the following milestones.

pnadolny13 commented 2 years ago

In GitLab by @iroussos on Nov 5, 2019, 07:32

@DouweM what do you think about this one?

Should we leave it as it is now and ask for the full URL, e.g. https://gitlab.com/api/v4 in the case of gitlab.com, or should we only ask for the base url, e.g. https://gitlab.com?

Either way we are locked on the v4 features right now and most probably we'll update it to whatever version comes next if Gitlab's API releases a new version.

pnadolny13 commented 2 years ago

In GitLab by @DouweM on Nov 5, 2019, 07:52

@iroussos Since the tap will necessarily be tied to a specific version, hardcoding it inside the tap (and thus not allowing/requiring it to be configured) by only asking for the base URL makes sense to me!

pnadolny13 commented 2 years ago

In GitLab by @iroussos on Nov 6, 2019, 14:40

mentioned in merge request !20

pnadolny13 commented 2 years ago

In GitLab by @iroussos on Nov 6, 2019, 14:55

closed via merge request !20

pnadolny13 commented 2 years ago

In GitLab by @iroussos on Nov 6, 2019, 14:55

mentioned in commit 2a1f04faba94c55a82e311b72d89afb963c1e6a6

pnadolny13 commented 2 years ago

In GitLab by @iroussos on Nov 6, 2019, 15:21

mentioned in merge request meltano!1132