search

MeltanoLabs / tap-gitlab

Singer.io Tap for extracting data from Gitlab's API
GNU Affero General Public License v3.0
8 stars 25 forks source link

Fail hard if request for group or project 404s #21

Closed pnadolny13 closed 2 years ago

pnadolny13 commented 2 years ago

In GitLab by @DouweM on Dec 4, 2019, 15:39

If the user has configured group(s) and project(s), hitting a 404 on /api/v4/group/<group_path> or /api/v4/project/<project_path> indicates that the entity does not exist or that the user does not have access to it, which suggests the user misconfigured the tap.

Instead of ignoring these failures (which makes sense for 40x responses on other endpoints), I think we should fail hard so that the user will know that we cannot actually extract data from the group(s)/project(s) they explicitly said they were interested in.

pnadolny13 commented 2 years ago

In GitLab by @DouweM on Dec 4, 2019, 15:39

marked this issue as related to meltano#1352

pnadolny13 commented 2 years ago

In GitLab by @DouweM on Dec 4, 2019, 15:42

@iroussos We discussed this earlier today; what do you think?

pnadolny13 commented 2 years ago

In GitLab by @iroussos on Dec 6, 2019, 08:02

assigned to @iroussos

pnadolny13 commented 2 years ago

In GitLab by @iroussos on Dec 6, 2019, 08:03

This will be a really trivial fix.

I'll check it next week to make sure that 404s are returned by Gitlab's API only for the cases we have discussed.