search

MeltanoLabs / tap-gitlab

Singer.io Tap for extracting data from Gitlab's API
GNU Affero General Public License v3.0
8 stars 25 forks source link

Add tests #43

Open pnadolny13 opened 2 years ago

pnadolny13 commented 2 years ago

In GitLab by @tomelliff on Oct 21, 2020, 13:09

I've noticed that very few taps and targets seem to have tests but I felt particularly uncomfortable making an untested change despite the fact it was very small. https://github.com/transferwise/pipelinewise-tap-postgres/tree/master/tests shows a high quality tap that does have tests and it doesn't look too painful.

Would you accept a small MR to add the start of some tests for now and then we can expand them as we go and insist on tests for any new functionality?

pnadolny13 commented 2 years ago

In GitLab by @DouweM on Oct 27, 2020, 14:42

Would you accept a small MR to add the start of some tests for now and then we can expand them as we go and insist on tests for any new functionality?

@tomelliff Definitely, please do!