MeltanoLabs / tap-gitlab

Singer.io Tap for extracting data from Gitlab's API
GNU Affero General Public License v3.0
8 stars 25 forks source link

added all parameter to load commits from all branches #63

Closed ninomllr closed 1 year ago

ninomllr commented 2 years ago

Added the all all parameter to the commits call to load all commits, not just the ones in the master branch as specified here: https://docs.gitlab.com/ee/api/commits.html

pnadolny13 commented 2 years ago

@ninomllr Thanks for the contribution! I left a couple comments, let me know what you think.

It also looks like you fixed some formatting in the code (which is good) but its a bit hard to understand what is being changed, is it possible to either flag anything thats materially changed or split this into two separate PRs, one for formatting and one for the actual code changes?

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sakce commented 2 years ago

Hi, @ninomllr ! Just curious, what's the status of this PR? Evaluating Airbyte and Meltano, and if I land on Meltano - I'd love to jump and finish it up if there's anything that needs picking up 🤝

ninomllr commented 2 years ago

Hi, @ninomllr ! Just curious, what's the status of this PR? Evaluating Airbyte and Meltano, and if I land on Meltano - I'd love to jump and finish it up if there's anything that needs picking up handshake

I don't really have great news. I haven't worked on this yet... i am really sorry! I was really under water lately and hope to find time again. Actually it wouldn't be a big change, but other customer projects have just been a priority lately.

pnadolny13 commented 1 year ago

@ninomllr @sakce any update on this PR?

tayloramurphy commented 1 year ago

Closing due to inactivity.