MeltanoLabs / tap-gitlab

Singer.io Tap for extracting data from Gitlab's API
GNU Affero General Public License v3.0
11 stars 29 forks source link

Config fixes #67

Closed laurentS closed 2 years ago

laurentS commented 2 years ago

This PR fixes 2 minor bugs:

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

laurentS commented 2 years ago

Not sure how strict you want to be with the code smells that sonar cloud detects.

ericboucher commented 2 years ago

Looks good to me @laurentS. I don't think the code smell is a problem here but I'll let @aaronsteers chime in.

aaronsteers commented 2 years ago

@ericboucher and @laurentS - Looks great. Thanks!

aaronsteers commented 2 years ago

@laurentS - Sorry, I didn't catch this at the time originally. There's actually a bug in the SDK related to falsey defaults not being applied to config. I found this issue and authored a patch MR here: https://gitlab.com/meltano/sdk/-/merge_requests/265

After this upstream fix, any config entry with a default specified should be accessible via config[setting_name] without having to provide get(..., fallback) syntax and without fear of KeyError.