Closed laurentS closed 2 years ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.0% Duplication
Not sure how strict you want to be with the code smells that sonar cloud detects.
Looks good to me @laurentS. I don't think the code smell is a problem here but I'll let @aaronsteers chime in.
@ericboucher and @laurentS - Looks great. Thanks!
@laurentS - Sorry, I didn't catch this at the time originally. There's actually a bug in the SDK related to falsey defaults not being applied to config. I found this issue and authored a patch MR here: https://gitlab.com/meltano/sdk/-/merge_requests/265
After this upstream fix, any config entry with a default specified should be accessible via config[setting_name]
without having to provide get(..., fallback)
syntax and without fear of KeyError
.
This PR fixes 2 minor bugs: