Config fixes - Githubissues

MeltanoLabs / tap-gitlab

Singer.io Tap for extracting data from Gitlab's API

GNU Affero General Public License v3.0

8 stars 25 forks source link

Config fixes #67

Closed laurentS closed 2 years ago

laurentS commented 2 years ago

This PR fixes 2 minor bugs:

makes optional config settings really optional (the tap was crashing before if theses were absent from config)
updates the README for more consistency between the table of config options and explanations below (and the code)

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

laurentS commented 2 years ago

Not sure how strict you want to be with the code smells that sonar cloud detects.

ericboucher commented 2 years ago

Looks good to me @laurentS. I don't think the code smell is a problem here but I'll let @aaronsteers chime in.

aaronsteers commented 2 years ago

@ericboucher and @laurentS - Looks great. Thanks!

aaronsteers commented 2 years ago

@laurentS - Sorry, I didn't catch this at the time originally. There's actually a bug in the SDK related to falsey defaults not being applied to config. I found this issue and authored a patch MR here: https://gitlab.com/meltano/sdk/-/merge_requests/265

After this upstream fix, any config entry with a default specified should be accessible via config[setting_name] without having to provide get(..., fallback) syntax and without fear of KeyError.