Closed laurentS closed 2 years ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.0% Duplication
Actually, it looks like you might need to start CI checks manually...
Thinking a bit more about it, this could expose some sensitive information (vulnerabilities for instance). I'm not sure what the best option is:
tap-github
so that the data is not fetched, but tests pass anyway. Possibly even make that conditional on the tap running in CI by checking for some env var, or add a config option to skip sensitive streams.Logging much after the fact...
This PR will appear broken at first:
GITLAB_PRIVATE_TOKEN
to a valid one withread_api
permissions.GITLAB_PROJECTS_TO_FETCH
optionally to test running all streams. I would suggestmeltano/sdk
along with a private token above that has full read access to the repo (including pipelines/vulnerabilities streams for which I'm getting HTTP 403)@aaronsteers can I suggest you set these up? Once done, the CI checks on the PR should turn green, and we should be able to merge other PRs a bit more comfortably.