search

MeltanoLabs / tap-gitlab

Singer.io Tap for extracting data from Gitlab's API
GNU Affero General Public License v3.0
11 stars 29 forks source link

docs: added info about graphql config to README #95

Closed tkaklam closed 1 year ago

tkaklam commented 1 year ago

Added info about the GraphQL config to the readme. Without this info, people who run on a different server than gitlab.com will run REST API requests against whatever is configured in api_url, but graphQL requests will still go to gitlab.com.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

tkaklam commented 1 year ago

not sure why pytest is failing. I didn't edit code, only the readme.

laurentS commented 1 year ago

@tayloramurphy looking at the logs (twice, after retrying the failing run), I think there's an API token problem. Did it expire or is there some permissions issue? The job keeps failing on a query for group labels for meltano/infra: /api/v4/groups/13315624/labels

tayloramurphy commented 1 year ago

@aaronsteers @WillDaSilva does this problem seem familiar to you all?

WillDaSilva commented 1 year ago

@tayloramurphy It's not familiar, but after looking at the logs I agree with @laurentS

tayloramurphy commented 1 year ago

@WillDaSilva has anything changed with the tokens that you know of? @ericboucher any thoughts here as well?

WillDaSilva commented 1 year ago

@tayloramurphy The GITLAB_PRIVATE_TOKEN action secret in this repository was last updated on 2022-05-09. Maybe it expired? I don't know whose token it is.

We could generate a new one using the MeltyBot or Meltano GitLab account, and then update the action secret. It wouldn't be difficult, so it might be worth a shot, but then we'll be responsible for ensuring that the token is not misused. That is true whether or not updating the token fixes the problem, since we cannot reverse the update, and the current token value is not known (to me at least).

laurentS commented 1 year ago

I think we talked with @edgarrmondragon and @aaronsteers about setting up these tokens in https://github.com/MeltanoLabs/tap-gitlab/pull/69, hopefully it might help figure out where they came from? Or is it that gitlab has a new scope delineation for permissions on the API following some upgrade?

aaronsteers commented 1 year ago

@WillDaSilva - I logged in to GitLab with the tap-gitlab service account (login info in 1Password) and confirmed that the token is still active.

image

I think the problem here is that we're running under a fork and the fork doesn't have access to the secret.

aaronsteers commented 1 year ago

Given that this only modifies the README, I'm inclined to go ahead and use Admin permissions to merge without tests passing.

@tkaklam - Thanks very much for this contribution!