MeltanoLabs / tap-hubspot

Other
1 stars 7 forks source link

feat: de-nest properties #57

Closed pnadolny13 closed 1 year ago

pnadolny13 commented 1 year ago

@edgarrmondragon what do you think about de-nesting these properties? For these streams I basically get a single properties dict in my destination with all the data nested. I know the target can flatten records but this seems like the job of the tap since its basically just parsing the API output to retrieve the actual data. Do you remember this ever coming up during development as an intentional feature?

This PR:

I ran the tests similar to what I described in https://github.com/MeltanoLabs/tap-hubspot/issues/56 and all the same tests passed.