search

MeltanoLabs / tap-hubspot

Other
1 stars 5 forks source link

fix CI test failures #68

Open pnadolny13 opened 8 months ago

pnadolny13 commented 8 months ago

Since our credentials dont have access to these streams, they cause failures in CI. I think for now it would be best to exclude those from the tests.

@kgpayne do you know an easy way to exclude certain streams from the test framework? I wasnt able to figure it out.

faultymajority commented 8 months ago

Seems like crm.objects.feedback_submission.read doesn't work for all accounts (https://developers.hubspot.com/docs/api/working-with-oauth#scopes) -- e.g. for ours. Can streams be excluded when running? Otherwise the meltano run just aborts midway.

edgarrmondragon commented 8 months ago

Can streams be excluded when running? Otherwise the meltano run just aborts midway.

@faultymajority They can! See https://docs.meltano.com/concepts/plugins/#select-extra if you're using Meltano, or https://github.com/singer-io/getting-started/blob/master/docs/DISCOVERY_MODE.md#metadata if you're not 🙂

faultymajority commented 7 months ago

Thanks! Should have RTFM :sweat_smile: meltano config tap-hubspot set _select_filter '["!feedback_submissions.*"]' did the trick.