search

MeltanoLabs / tap-salesforce

Singer.io tap for the Salesforce API
GNU Affero General Public License v3.0
1 stars 30 forks source link

client_id should not be a required param when PasswordCredentials are used #4

Closed MeltyBot closed 2 years ago

MeltyBot commented 5 years ago

Migrated from GitLab: https://gitlab.com/meltano/tap-salesforce/-/issues/4

Originally created by @iroussos on 2018-12-12 14:08:55

client_id is a required config param even when PasswordCredentials are used in tap-salesforce's config.

CRITICAL Cannot create credentials from config.
...
  File "/home/iroussos/work/code/singer/tap-salesforce/tap_salesforce/salesforce/credentials.py", line 31, in parse_credentials
    raise Exception("Cannot create credentials from config.")
Exception: Cannot create credentials from config.

I made the tap run just by having "client_id": "secret_client_id", so this is a value not used/checked.

Also, we should update the README with info on the config options.

MeltyBot commented 2 years ago

View 7 previous comments from the original issue on GitLab