search

MeltanoLabs / tap-snowflake

Other
4 stars 9 forks source link

Bug: Package version `could not be detected` #8

Open pnadolny13 opened 1 year ago

pnadolny13 commented 1 year ago

I noticed that the package version looks to not have been updated when the release tag was created.

Running:

meltano invoke tap-snowflake --version

Returns:

tap-snowflake v[could not be detected], Meltano SDK v0.14.0

Maybe thats what it returns when the version is 0.0.0?

cc @kgpayne

kgpayne commented 1 year ago

Thanks @pnadolny13 🙏 On it here 🙂

pnadolny13 commented 1 year ago

@kgpayne I'm still seeing this even with the changes from https://github.com/meltano/sdk/pull/1241. Or is this repo missing any updates that didnt get pulled in from the SDK changes?

kgpayne commented 1 year ago

Ah, the version detection changes were removed from that PR, in favour of meltano/sdk#1403 🙂