search

MeltanoLabs / target-athena

Singer.io Target for AWS Athena.
Other
5 stars 16 forks source link

Offer serde override as config option #18

Open andrewcstewart opened 3 years ago

andrewcstewart commented 3 years ago

Use case: user may want to select alternative serde.

visch commented 2 years ago

I wonder if the default should switch to a JSON file instead of a csv, re #27

andrewcstewart commented 2 years ago

@visch - Yes that is what I would recommend for now. The CSV serialization logic is inherited from the target that this was originally cloned from.

See also #6

visch commented 2 years ago

@visch - Yes that is what I would recommend for now. The CSV serialization logic is inherited from the target that this was originally cloned from.

See also #6

Got it! So a pr changing the default, and adding to the readme? Does that seem like the best next steps @andrewcstewart ?

andrewcstewart commented 2 years ago

If you want to, yes that would be great!