Packages are not created with the version for the Python module set. There is no automation to build and deploy the package to any type of registry.
Proposed changes
Set the version in the pyproject.toml file to 1.4.1, then set a tag to match. Without this, there is no way to specify a specific version of the module (all builds are set to version 0.0.1), which will pose issues for future breaking changes.
Add .gitlab-ci.yml file for Gitlab CI. This is a generic CI that should work with any recent Gitlab server with the Package Registry. It also uses the Dependency Proxy in the CI to pull the docker image for Python to avoid issues with Docker Hub's rate limiting. This requires the Dependency Proxy setup on the Gitlab server also. Note, however, that the .gitlab.yml file is non-functional on a Github server, and will only take effect if the project is pushed to a Gitlab server.
Types of changes
What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
Checklist
[ ] Description above provides context of the change
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Unit tests for changes (not needed for documentation changes)
[ ] CI checks pass with my changes
[ ] Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
[ ] Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
[ ] Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
tayloramurphy
commented
1 year ago
Problem
Packages are not created with the version for the Python module set. There is no automation to build and deploy the package to any type of registry.
Proposed changes
Set the version in the pyproject.toml file to 1.4.1, then set a tag to match. Without this, there is no way to specify a specific version of the module (all builds are set to version 0.0.1), which will pose issues for future breaking changes.
Add .gitlab-ci.yml file for Gitlab CI. This is a generic CI that should work with any recent Gitlab server with the Package Registry. It also uses the Dependency Proxy in the CI to pull the docker image for Python to avoid issues with Docker Hub's rate limiting. This requires the Dependency Proxy setup on the Gitlab server also. Note, however, that the .gitlab.yml file is non-functional on a Github server, and will only take effect if the project is pushed to a Gitlab server.
Types of changes
What types of changes does your code introduce to PipelineWise? Put an
xin the boxes that applyChecklist
setup.pyis an individual PR and not mixed with feature or bugfix PRs[AP-NNNN](if applicable. AP-NNNN = JIRA ID)AP-NNN(if applicable. AP-NNN = JIRA ID)