MeltanoLabs / target-athena

Singer.io Target for AWS Athena.
Other
5 stars 16 forks source link

bump sdk version #41

Closed aaronsteers closed 1 year ago

aaronsteers commented 2 years ago

Problem

Describe the problem your PR is trying to solve

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to PipelineWise? Put an x in the boxes that apply

Checklist

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

pnadolny13 commented 1 year ago

@aaronsteers any reason why this wasnt merged? It looks like when I used it in Squared I was pinning to this branch so I wonder if theres some good new features as part of this that I needed.

aaronsteers commented 1 year ago

@pnadolny13 - I think it was only holding on being merged until some test data was available. If you believe it was running well in squared, I think it's safe to merge. But I didn't have any ability to test on my side.

pnadolny13 commented 1 year ago

@aaronsteers yeah before I stopped using athena I was pinning to this branch so I'm fairly confident that it was working well. I'll go ahead and merge it.