Remove table name hyphens

[pnadolny13]

Problem

Describe the problem your PR is trying to solve

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Related to https://github.com/MeltanoLabs/target-athena/issues/33. Tables fail to get created when the stream name include hyphens which are not allowed.

Types of changes

What types of changes does your code introduce to PipelineWise? Put an x in the boxes that apply

• [x] Bugfix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Documentation Update (if none of the other choices apply)

Checklist

• [x] Description above provides context of the change
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] Unit tests for changes (not needed for documentation changes)
• [ ] CI checks pass with my changes
• [ ] Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
• [ ] Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
• [ ] Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
• [ ] Commits follow "How to write a good git commit message"
• [ ] Relevant documentation is updated including usage instructions

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[aaronsteers]

@pnadolny13 - By chance do you have time to log this as an issue in the SDK? Historically, the dash has been used as a delimiter between table, scheme, and db name parts.

[pnadolny13]

By chance do you have time to log this as an issue in the SDK?

@aaronsteers Done! https://gitlab.com/meltano/sdk/-/issues/344

[aaronsteers]

Thanks, @pnadolny13 !