MeltanoLabs / target-snowflake

Singer Target for the Snowflake cloud Data Warehouse
https://hub.meltano.com/loaders/target-snowflake--meltanolabs/
Other
10 stars 24 forks source link

feat: Support writing full record to a single variant column #100

Open pnadolny13 opened 1 year ago

pnadolny13 commented 1 year ago

target-bigquery provides the option to either denormalize into columns or leave as a single json column. That could be a useful feature for this target also.

target-bigquery docs:

Denormalized variants indicate data is unpacked during load with a resultant schema in BigQuery based on the tap schema. Non-denormalized means we have a fixed schema which loads all data into an unstructured JSON column. They are both useful patterns. The latter allowing BigQuery to work with schemaless or rapidly changing sources such as MongoDB instantly, while the former is more performant and convenient to start modeling quickly.

DouweM commented 1 year ago

@pnadolny13 I think this would be a great setting handled by the target SDK for any (database) destinations that support JSON objects!

tayloramurphy commented 1 year ago

@pnadolny13 or @edgarrmondragon do we have a relevant SDK issue for this? Would be good to get it in there.

We do have some interest from a prospect for this.

edgarrmondragon commented 1 year ago

@pnadolny13 or @edgarrmondragon do we have a relevant SDK issue for this? Would be good to get it in there.

We do have some interest from a prospect for this.

@tayloramurphy I don't think there is one. I'm logging it.

edgarrmondragon commented 1 year ago

@tayloramurphy I don't think there is one. I'm logging it.

See ~https://github.com/meltano/sdk/issues/699~ https://github.com/meltano/sdk/issues/1883

edgarrmondragon commented 1 year ago

@tayloramurphy I meant to link https://github.com/meltano/sdk/issues/1883 😅

tjvananne commented 11 months ago

+1 for loading JSON data into variant fields. We have some deeply-nested JSON fields that we prefer to not flatten at load time.

This is how the transferwise variant of target-snowflake works today, but we're actively working on moving away from that variant (it sometimes isn't compatible with non-transferwise taps).