MeltanoLabs / target-snowflake

Singer Target for the Snowflake cloud Data Warehouse
https://hub.meltano.com/loaders/target-snowflake--meltanolabs/
Other
10 stars 24 forks source link

bug: special characters in password cause authentication failures #281

Closed pnadolny13 closed 1 month ago

pnadolny13 commented 1 month ago

Related to https://github.com/snowflakedb/snowflake-sqlalchemy?tab=readme-ov-file#escaping-special-characters-such-as---signs-in-passwords. The tap will hit authentication failures if the password has special characters in it. Sqlalchemy suggests that they be encoded using:

import urllib.parse
urllib.parse.quote("kx@% jj5/g")

One backwards compatibility thing is that some users may have already hit this and manually encoded their password. In that case we shouldnt double encode it. We could attempt a login and if authentication fails, attempt a second login with the encoded version of the password or just bump the release version and warn of a change to the defaults.