MeltwaterArchive / datasift-dotnet

The official .NET API library for DataSift.
MIT License
12 stars 6 forks source link

Feature/fix json dot notation #6

Closed richard-delorenzi closed 9 years ago

richard-delorenzi commented 11 years ago

There was a problem with dots in json keys: the c# api uses a dot notation to describe the path to an element, this causes a problem when a key has a dot.

A fix was made to allow dots in keys, by escaping them (when used in this dot notation). The escaped dot is not valid json, so is unambiguous, when escaping valid json.

The change should not change the behaviour in cases when the old way worked. Unit tests where added to check the fix, and to check that it does not break anything.

see: https://jiradatasift.atlassian.net/browse/ALT-28

dugjason commented 9 years ago

Closing stale PR - Library has been totally rewritten since this PR was issued.