Make the dead connection detection thread a daemon thread.

MeltwaterArchive / datasift-java

Java client to interface with DataSift

http://www.datasift.com/

MIT License

10 stars 7 forks source link

Make the dead connection detection thread a daemon thread. #103

Closed scubasau closed 8 years ago

scubasau commented 8 years ago

Currently ConnectionManager statically instantiates a "dead-connections-monitor" thread as a non-daemon thread which prevents processes from exiting in a normal fashion. I believe this static instantiation - with no lifecycle hooks!!! - needs to be rethought, but as a decent workaround marking the thread as daemon should suffice.

zcourts commented 8 years ago

Thanks, there are a few relatively minor things like this than needs to change and should happen soon as I'll be getting some time to revisit this (inc in v3.2.13)