search

MeltwaterArchive / dropwizard-extra

A set of miscellaneous and common Dropwizard utilities
109 stars 45 forks source link

Various fixes and updates #19

Closed ramv closed 10 years ago

ramv commented 10 years ago
  1. Fixed typo in KafkaConsumerFactory.java
  2. Updated KafkaProducerFactory.java http://kafka.apache.org/documentation.html#producerconfigs
  3. Added test to verify that all settings are being populated correctly
  4. Make the settings keys in yaml identical to settings keys in kafka
  5. Added an example application that consumes a topic and produces on an other topic.
ramv commented 10 years ago

@nicktelford can you please review my pull request?

nicktelford commented 10 years ago

Could you do me favour and separate the example application out in to another branch and make a separate Pull Request for that? In general, it's best to submit smaller units of work as they're much easier to review in isolation.

cbumgard commented 10 years ago

+1 I'd love to see this pull-request merged

nicktelford commented 10 years ago

OK, so I've added support for Kafka 0.8 producers in c20e11e. Let me know if you have any issues.