search

MeltwaterArchive / dropwizard-extra

A set of miscellaneous and common Dropwizard utilities
109 stars 45 forks source link

fixes currator healthcheck #20

Closed fsaintjacques closed 10 years ago

fsaintjacques commented 10 years ago

Previous check would always fail when a namespace was provided:

! zookeeper-curator-localhost:2181-data-state: ERROR ! Path must not end with / character

java.lang.IllegalArgumentException: Path must not end with / character at org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:58) at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1020) at com.netflix.curator.framework.imps.ExistsBuilderImpl$2.call(ExistsBuilderImpl.java:171) at com.netflix.curator.framework.imps.ExistsBuilderImpl$2.call(ExistsBuilderImpl.java:160) at com.netflix.curator.RetryLoop.callWithRetry(RetryLoop.java:106) at com.netflix.curator.framework.imps.ExistsBuilderImpl.pathInForeground(ExistsBuilderImpl.java:156) at com.netflix.curator.framework.imps.ExistsBuilderImpl.forPath(ExistsBuilderImpl.java:147) at com.netflix.curator.framework.imps.ExistsBuilderImpl.forPath(ExistsBuilderImpl.java:35) at com.datasift.dropwizard.curator.health.CuratorHealthCheck.check(CuratorHealthCheck.java:39) at com.yammer.metrics.core.HealthCheck.execute(HealthCheck.java:195)

fsaintjacques commented 10 years ago

would it be possible to backport this for 0.6.2?

nicktelford commented 10 years ago

Fixed in 8a6be99dc53504649a4c3168b7a73666bb9f30c6