search

MeltwaterArchive / dropwizard-extra

A set of miscellaneous and common Dropwizard utilities
109 stars 45 forks source link

Dropwizard Extra ZooKeeper #4

Closed jairamc closed 11 years ago

jairamc commented 11 years ago

Added a new module that introduces ZooKeeper integration in Dropwizard.

nicktelford commented 11 years ago

Excellent, I'm glad someone else feels a need for this, I've been working on a dropwizard-extra-zookeeper module as part of some integration with Netflix's Curator in a branch: https://github.com/datasift/dropwizard-extra/tree/feature/zookeeper-curator

My one suggestion would be to manage the ZooKeeper client instance using composition, rather than inheritance; something like this: https://github.com/datasift/dropwizard-extra/blob/feature/zookeeper-curator/dropwizard-extra-zookeeper/src/main/java/com/datasift/dropwizard/zookeeper/ManagedZooKeeper.java

Otherwise, looks good and I'm more than happy to merge.

nicktelford commented 11 years ago

BTW: the other features I'm working on are a revised HealthCheck for ZooKeeper connections and to fully instrument them with metrics. Some of this I've yet to push up to github so you won't be able to see it yet.