search

MelvilQ / noten-lernen

Learn to read sheet music
MIT License
45 stars 27 forks source link

Question - should android app with midi use any octave note? #51

Open QuantumBob opened 2 months ago

QuantumBob commented 2 months ago

Great app. I have one question though. When using the web app with keyboard attached to midi, only the correct octave note gives a right answer (ie only c5 correct for c5 on treble clef). But on android app, with midi keyboard attached, all c notes (any octave) on my keyboard give right answer to any c on treble OR bass clef. Is this correct behaviour or am I doing something wrong? If app is working as it should, getting the android app to work like web app would be great. Thanks again!

code-monet commented 1 month ago

That's odd and unexpected. The way it is implemented we should be checking for the correct octave when the input is MIDI. I'll confess I didn't test the code on my phone as I was unable to get it to build :(

code-monet commented 1 month ago

Actually, I'm guessing you're using the latest code on the web, which includes the above PR, but the Android release doesn't have it yet, so it's probably just a matter of version difference.