Open fisforfaheem opened 3 years ago
Melvin-Abraham
commented
3 years ago @fisforfaheem Unfortunately this cannot be achieved so soon since one of the dependencies uses a native module (grpc) which currently does not compile for the latest version of electron runtime...
fisforfaheem
commented
3 years ago or atleast to version 11 if possible? becases 9 is tooo old.
On Sat, Feb 13, 2021 at 11:40 AM Melvin. L. Abraham < notifications@github.com> wrote:
@fisforfaheem https://github.com/fisforfaheem Unfortunately this cannot be achieved so soon since one of the dependencies uses a native module ( grpc) which currently does not compile for the latest version of electron runtime...
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Melvin-Abraham/Google-Assistant-Unofficial-Desktop-Client/issues/106#issuecomment-778572450, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRXJSE6IIW5CSIINWZVM4DS6YNEBANCNFSM4XRP7QWQ .
Melvin-Abraham
commented
3 years ago @fisforfaheem Currently I am thinking of forking the dependency and switching to a non-native module and if that hopefully works, I'll probably update the electron version...
fisforfaheem
commented
3 years ago Sounds good, thanks! Looking forward also if possible make a 2021 release of app soon
On Sat, Feb 13, 2021, 4:44 PM Melvin. L. Abraham notifications@github.com wrote:
@fisforfaheem https://github.com/fisforfaheem Currently I am thinking of forking the dependency and switching to a non-native module and if that hopefully works, I'll probably update the electron version...
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Melvin-Abraham/Google-Assistant-Unofficial-Desktop-Client/issues/106#issuecomment-778605208, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRXJSEPUHM37MXIATAZHTTS6ZQYHANCNFSM4XRP7QWQ .
fisforfaheem
commented
3 years ago Please do update the app!
cjmaria
commented
3 years ago This would also be a critical update for individuals with M1-based Apple computers. Electron <11 is not supported on the M1 chip, and those building on this platform will see the error: HTTPError: Response code 404 (Not Found) for https://github.com/electron/electron/releases/download/v10.3.2/electron-v10.3.2-darwin-arm64.zip during npm install. Thank you for all your work :)
fisforfaheem
commented
3 years ago Thanks for the tip! , I didn't knew that, but on windows 10 it would work like a charm, current version really needs some active development
On Sat, Apr 10, 2021, 6:15 AM Chris Maria @.***> wrote:
This would also be a critical update for individuals with M1-based Apple computers. Electron <11 is not supported on the M1 chip, and those building on this platform will see the error: HTTPError: Response code 404 (Not Found) for https://github.com/electron/electron/releases/download/v10.3.2/electron-v10.3.2-darwin-arm64.zip during npm install. Thank you for all your work :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Melvin-Abraham/Google-Assistant-Unofficial-Desktop-Client/issues/106#issuecomment-817047531, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRXJSE453GWAFEMA5S6MG3TH6RBLANCNFSM4XRP7QWQ .
CorvetteCole
commented
3 years ago Electron desperately needs an update to at least 11
CorvetteCole
commented
3 years ago I managed to build and run this using electron 11.4.10 as a dependency, so it is possible. There are some bugs with chromium's ozone implementation but if you don't use that (read: 99% of people), it is flawless. Have been using for a few months.
My package.json is below:
{
"name": "g-assist",
"productName": "Google Assistant",
"description": "Google Assistant Unofficial Desktop Client",
"version": "1.0.0-rc.2",
"private": true,
"author": "Melvin Abraham <melvinredvirus@gmail.com>",
"homepage": "https://github.com/Melvin-Abraham",
"repository": {
"url": "https://github.com/Melvin-Abraham"
},
"bugs": {
"url": "https://github.com/Melvin-Abraham/issues"
},
"license": "Apache-2.0",
"keywords": [
"google-assistant",
"google-assistant-sdk",
"electron-app",
"virtual-assistant",
"desktop-app",
"electron",
"assistant",
"cross-platform"
],
"main": "app.js",
"build": {
"appId": "com.redvirus.g-assist",
"files": [
"app/**/*",
"node_modules/**/*",
"package.json",
"app.js"
],
"directories": {
"buildResources": "app/res/misc/*"
},
"publish": [
{
"provider": "github",
"owner": "Melvin-Abraham",
"repo": "Google-Assistant-Unofficial-Desktop-Client"
}
],
"win": {
"target": [
{
"target": "nsis",
"arch": [
"x64",
"ia32"
]
}
],
"icon": "./app/res/icons/favicon.ico"
},
"nsis": {
"oneClick": "false",
"artifactName": "${productName}-Setup-${version}.${ext}",
"allowToChangeInstallationDirectory": "true",
"installerIcon": "./app/res/icons/Installer.ico",
"installerSidebar": "./app/res/misc/InstallerSidebar.bmp",
"uninstallerSidebar": "./app/res/misc/UninstallerSidebar.bmp"
},
"mac": {
"icon": "./app/res/icons/icon.icns",
"category": "public.app-category.productivity",
"target": [
"dmg",
"zip"
],
"darkModeSupport": true
},
"dmg": {
"background": "./app/res/misc/DMG Background.png",
"icon": "./app/res/icons/icon.icns",
"iconSize": 100,
"contents": [
{
"x": 350,
"y": 280,
"type": "link",
"path": "/Applications"
},
{
"x": 80,
"y": 280,
"type": "file"
}
],
"window": {
"width": 600,
"height": 410
}
},
"linux": {
"artifactName": "${productName}-Setup-${version}-${arch}.${ext}",
"category": "Productivity",
"target": [
"pacman"
],
"icon": "./app/res/icons/icon.icns"
},
"snap": {
"confinement": "strict",
"grade": "stable",
"plugs": [
"default",
"audio-record"
]
}
},
"scripts": {
"start": "electron .",
"start:verbose": "electron . --verbose",
"dist": "electron-builder",
"pack": "electron-builder --dir",
"lint": "eslint .",
"preinstall": "npm install git://github.com/Melvin-Abraham/google-assistant.git#g-assist",
"postinstall": "electron-builder install-app-deps"
},
"dependencies": {
"bumblebee-hotword": "0.2.1",
"electron-is-accelerator": "^0.2.0",
"electron-log": "^4.3.5",
"electron-updater": "^4.3.9",
"google-assistant": "github:Melvin-Abraham/google-assistant#g-assist",
"grpc": "1.24.11",
"node-fetch": "^2.6.1"
},
"devDependencies": {
"electron": "11.4.10",
"electron-builder": "22.11.7",
"eslint": "^7.27.0",
"eslint-config-airbnb": "^18.2.1",
"eslint-config-airbnb-base": "^14.2.1",
"eslint-plugin-import": "^2.23.3",
"prettier": "^2.3.0"
}
}@Melvin-Abraham
im-coder-lg
commented
3 years ago Wait a minute... This is cool but won't it use a lot of performance?
fisforfaheem
commented
3 years ago This is Great Please merge it and make use of latest features and improvements
[image: Mailtrack] https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5& Sender notified by Mailtrack https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5& 09/14/21, 07:34:26 PM
On Tue, Sep 14, 2021 at 6:44 PM LG @.***> wrote:
Wait a minute... This is cool but won't it use a lot of performance?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Melvin-Abraham/Google-Assistant-Unofficial-Desktop-Client/issues/106#issuecomment-919164816, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRXJSEQE66CSOWNANY5VQDUB5GSRANCNFSM4XRP7QWQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
please use latest version of electron to get new things its very easy