search

Melvin-Abraham / Google-Assistant-Unofficial-Desktop-Client

A cross-platform unofficial Google Assistant Client for Desktop (powered by Google Assistant SDK)
Apache License 2.0
3.61k stars 410 forks source link

Ability to put google assistant client on an room at google home #604

Open Nhoque3786 opened 2 years ago

Nhoque3786 commented 2 years ago

This idea is about adding the function to add the GAUC as an device on google home app.

What this will help?

If you wanna just put "turn off the lights" or "change the light color to", instead of applying to all home's lights, this will only apply for the room lights the device is in

(you can sitll apply light stuff individually or by room just specificating by the room name or device name)

Melvin-Abraham commented 2 years ago

function to add the GAUC as an device on google home app

It is yet to be figured out at the moment as it's not supposedly possible to enable this feature out-of-the-box using the Google Assistant SDK.

If you wanna just put "turn off the lights" or "change the light color to", instead of applying to all home's lights, this will only apply for the room lights the device is in

Can you provide some screenshots (for both phone and GAUDC) with the proposed queries for which GAUDC is unable to resolve as expected?

Nhoque3786 commented 2 years ago

Hi! thanks for replying

It is yet to be figured out at the moment as it's not supposedly possible to enable this feature out-of-the-box using the Google Assistant SDK. that's a little bit unfortunate, but i can't understand about it Sorry about it, im still new to understand google assistant's SDK, and i just thinked that was possible

Can you provide some screenshots (for both phone and GAUDC) with the proposed queries for which GAUDC is unable to resolve as expected? as i use the prompt "turn off the lights on bedroom" it will turn off the two lights that are on my house with the name "room of [insert my name here and my sister's name]", as shown on the screenshots (one of my desktop using windows 10 using GSUDC on recent version 1.0.0 and one from my phone showing what happend)

(btw, its translated into portuguese, but the first screenshot shows google home responding "ok, turning 2 lights off", and the seccond is just my google home app) image

image (Sorry for the bad censure on the names, is a little bit hard to do this on google photos's editor)

On my opinion, maybe make the assistent ask for what specific room you wanna the lights on/off or maybe show some on/off buttons like GA on mobile?

(ignore the part that's 3AM, i waked up now and saw my github notifications, no one's sleep has been interrupted during the test)

Melvin-Abraham commented 2 years ago

Thank you @Nhoque3786, if there's any progress regarding this issue, it will be updated here and/or in similar issues :)

Nhoque3786 commented 2 years ago

Your welcome my friend :D