Melvin-Abraham / Google-Assistant-Unofficial-Desktop-Client

A cross-platform unofficial Google Assistant Client for Desktop (powered by Google Assistant SDK)
Apache License 2.0
3.61k stars 410 forks source link

[🐛 Bug]: Doesn't show any images and texts #606

Closed preetsuthar17 closed 2 years ago

preetsuthar17 commented 2 years ago

What went wrong?

Whenever I search for something using google assistant it gives me results but doesn't show any image or text to help me to fix it.

image image

What did you expect to happen?

Show images and text on search.

Steps to reproduce the bug

  1. ask the assistant for any diagram or something.
  2. see the error.

App Version

v1.0.0

OS Version

Windows 10 20H2 19042.1415

Relevant Assets

No response

Pre-submission Checklist

im-coder-lg commented 2 years ago

I kinda think we have seen this before and I also noticed this getting fixed with Personal Results instegration, so @Melvin-Abraham is it fine if I post the link here? I think Personal Results fixed this for me so it might work here too.

preetsuthar17 commented 2 years ago

I kinda think we have seen this before and I also noticed this getting fixed with Personal Results instegration, so @Melvin-Abraham is it fine if I post the link here? I think Personal Results fixed this for me so it might work here too.

Post it, please

sumeshir26 commented 2 years ago

@pritudev Here is the link: https://github.com/Melvin-Abraham/Google-Assistant-Unofficial-Desktop-Client/wiki/Setup-Authentication-for-Google-Assistant-Unofficial-Desktop-Client#enabling-personal-results-optional

im-coder-lg commented 2 years ago

If the wiki guide doesn't work, do tell us here, we'll help you out. Mostly I expect it's Account Linking, so we'll help you there.

preetsuthar17 commented 2 years ago

If the wiki guide doesn't work, do tell us here, we'll help you out. Mostly I expect it's Account Linking, so we'll help you there.

That authentication is already done but still not working

image

image

sumeshir26 commented 2 years ago

@pritudev Try this: https://gist.github.com/im-coder-lg/23fc93cbf983b36b21641563ed4f3d4e

preetsuthar17 commented 2 years ago

@pritudev Try this: https://gist.github.com/im-coder-lg/23fc93cbf983b36b21641563ed4f3d4e

Doesn't working... 😢

image

@sumeshir26 @im-coder-lg

Melvin-Abraham commented 2 years ago

I also noticed this getting fixed with Personal Results instegration ... I think Personal Results fixed this for me so it might work here too.

@im-coder-lg Can you share a screenshot of your assistant client for the queries asked by the OP?

im-coder-lg commented 2 years ago

It's on the gist, the Steve Jobs search, I used Personal results with Account Linking enabled.

preetsuthar17 commented 2 years ago

If we ask for any image for anything else it doesn't show anything

preetsuthar17 commented 2 years ago

image

im-coder-lg commented 2 years ago

Did you enable Account Linking? Also, did you follow all the steps?

preetsuthar17 commented 2 years ago

Did you enable Account Linking? Also, did you follow all the steps?

yeah

im-coder-lg commented 2 years ago

Wait, let me clone the repo and build from source, let's see.

preetsuthar17 commented 2 years ago

Did you enable Account Linking? Also, did you follow all the steps?

image

im-coder-lg commented 2 years ago

Testing this from my side, if it works, I will share the latest build with you and you can test that.

preetsuthar17 commented 2 years ago

Testing this from my side, if it works, I will share the latest build with you and you can test that.

Sure

im-coder-lg commented 2 years ago

Kinda feel dejected... This works: image But this doesn't: image I kinda think, since I have searched Steve Jobs on my mobile, it is appearing. So maybe I'll shut GAUDC down for now, search something like Turbo C or Qbasic images and do the same on GAUDC...

preetsuthar17 commented 2 years ago

it doesn't working like you did second time why Is there any fix?

preetsuthar17 commented 2 years ago

Kinda feel dejected... This works: image But this doesn't: image I kinda think, since I have searched Steve Jobs on my mobile, it is appearing. So maybe I'll shut GAUDC down for now, search something like Turbo C or Qbasic images and do the same on GAUDC...

image

Google Assistant on PC is helping me in a lot of things like assignments and questions but this is the only thing not working and it should fixed

im-coder-lg commented 2 years ago

Yeah... I expect the query is supposedly saved or something, and I am still testing the search in mobile, then GAUDC trick.

preetsuthar17 commented 2 years ago

Yeah... I expect the query is supposedly saved or something, and I am still testing the search in mobile, then GAUDC trick.

Okay

im-coder-lg commented 2 years ago

But, at the same time, the app is using the Google Assistant SDK, which is limited in its capabilities, compared to the Android Assistant, which uses the device itself. The SDK doesn't use the entire system though.

im-coder-lg commented 2 years ago

Well, Qbasic doesn't appear but the famous Never Gonna Give You Up(not intended to rickroll here) song does, which makes me think sus, I never searched it and it appeared, whereas I searched Qbasic but that doesn't? Maybe the SDK only queries frequently-searched searches only.

preetsuthar17 commented 2 years ago

What we are supposed to do now?

im-coder-lg commented 2 years ago

Well, this is a true bug. The best is to keep this open and use the browser for important searches and GAUDC for quick info like weather, etc.

preetsuthar17 commented 2 years ago

Well, this is a true bug. The best is to keep this open and use the browser for important searches and GAUDC for quick info like weather, etc.

so this thing will never fix?

im-coder-lg commented 2 years ago

Idk, but it's best to wait for a fix tho

93boba commented 2 years ago

It does show personal results. However, notes are unreadable due to a weird position on the screen. Except for Wikipedia, I am not getting any search results on PC. Is there a way to link PCassistant to a default web browser and show the first result from Google?

im-coder-lg commented 2 years ago

Not yet. If you do know a module that does just that, do tell us here!

TJ2005 commented 2 years ago

is there an update yet?

im-coder-lg commented 2 years ago

No :( did you get any idea to fix this here?