Melvin-Abraham / Google-Assistant-Unofficial-Desktop-Client

A cross-platform unofficial Google Assistant Client for Desktop (powered by Google Assistant SDK)
Apache License 2.0
3.58k stars 397 forks source link

[💡 Feature Request]: Discard duplicate queries when multiple devices are in the same room #613

Open DatDraggy opened 2 years ago

DatDraggy commented 2 years ago

What's the Problem?

First of all I want to say this project is amazing. I'd had been wanting to run google assistant on windows for a while but the last time I checked it wasn't possible. Thank you so much for your effort!

When there's more than one google assistant (for example my phone and a google nest mini) that heard my Hey Google query, all but one will discard and stop listening. Is it possible to add this feature to the desktop client too? Now when I use the hey google wake word, my phone or home mini will also run the query, resulting in it being run two times.

What's your solution or idea?

Add two options in the settings to either make the desktop client stop processing when another device heard me or make others stop listening and process the request on it's own, if possible.

Alternatives Considered

Disabling the wake word on desktop

App Version

Built from source

OS Version

Windows 10 Pro 21H2

Additional context

There is no option for the v1 release in the App Version. I installed it from winget today.

Pre-submission Checklist

TheCre8r commented 2 years ago

In the interim, it is possible to disable Hey Google / OK Google in the settings, but I agree this would be helpful.

image

Melvin-Abraham commented 2 years ago

@DatDraggy I don't think it will be possible to do it right away as the Google Assistant SDK probably doesn't provide such a granular information at the moment. Currently, it's not integrated with Google Home itself for the same reason...

Nonetheless, if there's any ideas or workarounds from community side, I'll be more than happy to look into it...

DatDraggy commented 2 years ago

@Melvin-Abraham I see. I guess I'll stick to hotkey and only virtual audio input without my mic. Thank you for the reply ^^