search

MelvinVermeer / eslint-plugin-no-relative-import-paths

90 stars 22 forks source link

Properly handle paths #24

Closed jgoux closed 1 year ago

jgoux commented 1 year ago

Fixes https://github.com/MelvinVermeer/eslint-plugin-no-relative-import-paths/issues/23

This bug was preventing VSCode ESLint extension to properly report the rule's error.

I also removed logic about defaulting rootDir to "" as it's already done when reading the context's options.

jgoux commented 1 year ago

Ping @MelvinVermeer, any chance you could review and release? 🙏

jgoux commented 1 year ago

@MelvinVermeer 👋 😅

haakemon commented 1 year ago

Would be great to get this merged, as I spent quite some time debugging today why VS Code and CLI reported different eslint issues related to import paths. After some digging, I came to thix exact conclusion and fix 😅 I should have checked github issues first... 🙃

jgoux commented 1 year ago

I'm using yarn patch currently until this is merged. 👍

haakemon commented 1 year ago

@MelvinVermeer Any chance of getting this reviewed/merged? 😊

tanchu commented 1 year ago

@MelvinVermeer merge plz