MelvorIdle / melvoridle.github.io

128 stars 20 forks source link

[Bug]: When opening the wiki in-game, Melvor will refuse to close on Steam until my browser is also closed. #3787

Open Nelots opened 11 months ago

Nelots commented 11 months ago

Describe the bug

When I click any of the in-game wiki buttons, the game will open my browser and load the wiki. After doing so, if I close Melvor Idle, Steam will still consider the game running until my browser is also closed. Because the game is considered running, it cannot be reopened in the meantime. Force stopping the game through Steam also has no effect. This will only happen if my browser was not already open when opening the wiki. Loading a different page on the browser, or opening a new tab and closing the old one, will not fix it; I have to close it entirely.

Some additional notes:

Reproduction Steps

  1. Make sure your default browser isn't already open.
  2. Click on any wiki button in-game. The game should open your default browser.
  3. Close Melvor Idle.
  4. Steam will not detect the game as closed. Until resolved, the game cannot be reopened, and attempting to force close it will do nothing.
  5. Close your browser.
  6. Steam should now detect that the game is closed.

Expected behaviour

Steam should detect that the game was closed the moment I close Melvor Idle.

Save Link - Required if issue occurs with a save

No response

Screenshots

The Wiki button. Any other button that opens my browser (such as clicking on the version number, which launches the Steam store page) will have the same effect. 1

Note Melvor Idle not being in the taskbar. This is Steam after closing the game. 2

Upon trying to force close the game through Steam. It never manages to close it successfully. 3

Note the browser in my taskbar is now closed. This is Steam after closing both Melvor Idle and my browser. 4


Alternatively, here's a 40-second screen recording of the issue.

https://github.com/MelvorIdle/melvoridle.github.io/assets/46813485/b626b579-a017-4ec8-b26a-7d630c6f161c

Console output

No response

Which platforms are you experiencing this bug on?

Which expansions are purchased and active at the time of the bug?

Which version of the game are you experiencing this bug on?

v1.2.1

Game Subversion

?7994

Are you using any mods?

No

MelvorIdle commented 1 month ago

Possibly related #3786

Paulgelissen commented 3 weeks ago

I've encountered this issue several times as well. Didn't know it had to do with the open browser, but just tested it and it is indeed the same issue.