search

MemVerge / nf-float

MemVerge Netflow Plugin
Apache License 2.0
13 stars 5 forks source link

Consider using HTTP API instead of `float` CLI #24

Open bentsherman opened 1 year ago

bentsherman commented 1 year ago

If you have a REST API for MemoryMachine Cloud, it would be nice to use that instead of the float CLI in your custom executor. That way, users don't even have to install the float command to get started (even though it is really easy and they'll probably do it anyway because it's useful). Also, a REST API should simplify your code because you won't have to construct the bash commands.

In this case you would only need to extend Executor rather than AbstractGridExecutor. The K8sExecutor in Nextflow is a good example of an executor that delegates to a REST API.

In any case, this issue is not urgent, and the float CLI should suffice in the meantime.

jealous commented 1 year ago

Thanks for the suggestion. Considering the effort required, we may not be able to do that in a short term.

bentsherman commented 1 year ago

Out of curiosity, do you have a REST API that you could use?

jealous commented 1 year ago

Yes, the command line actually talks to the REST API. But we don't have a lib for java platform.

bentsherman commented 1 year ago

If it's a REST API then you could just use an HTTP client, like K8sClient in Nextflow. But I understand if that would still be a lot of work to construct the HTTP calls properly.