Revamp new user process

MemberJunction / MJ

Main MemberJunction Repository

https://docs.memberjunction.org/

ISC License

4 stars 0 forks source link

Revamp new user process #645

Closed JS-BC closed 1 week ago

JS-BC commented 1 week ago

Notable changes:

When creating a new user, if the contextUser specified in the config file is not found, we default to using the first user in the user cache with the Owner Role
New users are given the UI role by default, rather than the Developer Role
When creating a UserInfo object to insert into the user cache, we now also pass in the RoleID
- This fixes a bug where we fail to read the UserRoles view due to searching for user permissions by ID, not by name.

AN-BC commented 1 week ago

@JS-BC this looks good to me overall, doesn't seem like it really changes the core logic in terms of when we allow the creation of a new user, it still has to be turned on in the config, and by default we do NOT allow the creation of a new user unless that setting is turned on. Assuming that's the case, which is key, because we don't want to auto create new users ever unless the installer sys admin sets it up this way, we are good and the clean up you did seems good to me.