search

MemePlace / Frontend

Frontend Repo
3 stars 0 forks source link

Auto card sizing algorithm #16

Closed xiningchen closed 6 years ago

xiningchen commented 6 years ago

Takes the memes that needs to be loaded and determine optimal height and width so that card placement fits the page width. In meme browsing mode, it should be height-fixed, while width can change.

bandgeekdante commented 6 years ago

Should this use the same branch as meme_cards? (or a branch off of that branch)

Step7750 commented 6 years ago

If @xiningchen is working on the actual cards, then you probably don't want to work on the same branch as her. You may want to wait until her branch is partially finished and/or merged before branching off of it.

Step7750 commented 6 years ago

https://github.com/SENG513/Frontend/pull/17 fixes this for height-fixed.

I think the only case remaining is width-fixed on mobile to encompass the full screen width.

bandgeekdante commented 6 years ago

I will implement the fixed width for mobile.

bandgeekdante commented 6 years ago

@xiningchen @Step7750 Where does height-fixing happen in the code? I tested this by adding an image and the height wasn't fixed