search

MemePlace / Frontend

Frontend Repo
3 stars 0 forks source link

Feature/mobile card width #27

Closed bandgeekdante closed 6 years ago

bandgeekdante commented 6 years ago

Currently every meme will be resized so as to fit device width in mobile. This may cause issues with very tall or wide memes (I added a wide meme and a tall meme for reference). Also the mobile cutoff of 1000px seems a bit too large; could we change it to 768px? I'm also reusing code across components because I don't know how to increase the scope of TypeScript functions. Lastly sorry for going a bit outside of the purpose of this branch by renaming "angular-project" but I would like Meme.Place to be consistent across the board (if a separate branch should be made for this let me know).

bandgeekdante commented 6 years ago

Oh I think I also pushed an update to "fsevents" in Angular; is that ok?

Step7750 commented 6 years ago

It's fine, you can create a utils class with static methods if you want to use them in many places and then just import it.

Step7750 commented 6 years ago

could we change it to 768px

Yes, I think that is the default that signifies mobile. How well does that work on tablets?

bandgeekdante commented 6 years ago

Depends on the tablet; for instance the iPad would render as mobile and iPad Pro would render it as desktop. Also a bunch of phones will render it as desktop when they're in landscape orientation (but I think that's fine personally).

Step7750 commented 6 years ago

:+1: