search

MemePlace / Frontend

Frontend Repo
3 stars 0 forks source link

Feature/community service #36

Closed Dave0921 closed 6 years ago

Dave0921 commented 6 years ago

I was wondering if I implemented the sorting URL correctly for getCommunities() and getCommunityTemplates(name: string).

Step7750 commented 6 years ago

Looks great! I think you can remove the comments above each method since the method name should be self explanatory.

Dave0921 commented 6 years ago

Okay I've fixed up the issues I believe. I also got the following linting error:

../app/api/community.service.ts[38, 67]: Shadowed name: 'community'

I'm getting this error at the line where I do a post request in the createCommunity() function:

createCommunity(community: Community): Promise<any> {
    return this.isCommunityNameAvailable(community.name).then((exists: boolean) => {
      if (!exists) {
        this.api.post(Version.v1, 'communities', community).then((community: Community) => {
...

Does this need to be resolved?

Dave0921 commented 6 years ago

I can't seem to do a merge due to branch conflicts (since I had to import the community services to api.module.ts). How do I resolve this?

Step7750 commented 6 years ago

You can resolve the conflicts directly on github with the new button at the bottom here.