search

MemePlace / Frontend

Frontend Repo
3 stars 0 forks source link

Community Favourites Duplicate #38

Open xiningchen opened 6 years ago

xiningchen commented 6 years ago

Not sure if it's just me, but currently the master branch contains code for the side navigation of communities. However when I favourite a community, it still shows up in the unfavourited with an empty yellow star and in the favourited... Since it shows up to the top of the community, I don't think we should have this duplication?

Dave0921 commented 6 years ago

Yeah, I intended that to happen, just cause sometimes, the favourited communities won't be in the top 10. That said, I can change the functionality so that it removes the community from the unfavourited list.

xiningchen commented 6 years ago

Oh lol... wait I'm confused... If that's actually what we want, then don't change it. It was just strange that it duplicated...

Dave0921 commented 6 years ago

Eh, having the favourites appear in the "top" community list on the side nav as well as in the favourites list might be a bit ugly looking/confusing. I'll change it.