search

MemePlace / Frontend

Frontend Repo
3 stars 0 forks source link

Meme Card Component #4

Closed Step7750 closed 6 years ago

Step7750 commented 6 years ago

Memes have to be represented to the user when browsing and must display the author and a way to vote on it. The component should have a way to bind the wanted height optionally with input binding or otherwise default. It should scale to a fixed height with dynamic width (and possibly a max width to prevent abuse).

The meme itself for now will just be an image that is represented by a URL on imgur, with our API server also returning the dimensions for the image so that the card can be created before waiting for the image to load.

xiningchen commented 6 years ago

Do I close this issue? Or should I wait because the height algorithm isn't complete yet.

Step7750 commented 6 years ago

Looks like it is fixed in #17. The height (and algo) is delegated by the parent, so it doesn't apply to this component.