search

MemePlace / Frontend

Frontend Repo
3 stars 0 forks source link

Fix/community favourite dup #41

Closed Dave0921 closed 6 years ago

Dave0921 commented 6 years ago

Modified the side navigation bar list so that it removes "Favourited" communities from the top community list. Also, added a favouriteCount property to the community object to keep track of the number of favourites per community (for sorting purposes).

Step7750 commented 6 years ago

I don't think we need to mock this data anymore, you can DI the community service and use it to fetch the top communities now. You can also use the UserService to check if they are logged in, and if so, display their favourites.

Dave0921 commented 6 years ago

Kk I'll use the community service.

Dave0921 commented 6 years ago

I'll add a NSFW tag beside the communities that are NSFW (maybe through a chip). I assume the sidebar text will appear somewhere on the right of the actual community page.

Dave0921 commented 6 years ago

I've implemented the community API service to get a list of top communities on loading the site. I'll work on added a NSFW tag in another PR.

xiningchen commented 6 years ago

Instead of having the details on a community in another side bar, maybe have it so that it's a header and creates a popup.

Dave0921 commented 6 years ago

Okay sure, that sounds good. Are you working on the Community page in one of the branches?

Dave0921 commented 6 years ago

This is unrelated to this bug, but is there a way to refresh/change the page on login/logout so that the user's favourited communities appear/disappear?

Step7750 commented 6 years ago

@Dave0921 Once https://github.com/MemePlace/Frontend/pull/62 merges, yes

Step7750 commented 6 years ago

You may want to modify this with #68 merged

Dave0921 commented 6 years ago

I have a strange bug that I can't seem to figure out how to fix. When I toggle the Favourite/Unfavourite icon on the Browse Community view, the changes are reflected in the Favourite communities list. However, the Unfavourited/Top 10 communities list doesn't seem to change. Is there a way for the Unfavourited communities list to detect changes from the star icon in the Browse Community view?

Step7750 commented 6 years ago

@Dave0921 What's the status on this?

Step7750 commented 6 years ago

This PR is a duplicate of #79