search

MemePlace / Frontend

Frontend Repo
3 stars 0 forks source link

Sidebar Interaction Fixes #52

Closed Step7750 closed 6 years ago

Step7750 commented 6 years ago

The side bar should remember if the user forcefully closed it or not and not reopen unless they explicitly open it again. By default the side bar should be open on desktop unless they close it.

Dave0921 commented 6 years ago

For this feature, should the side bar remember if it's closed or not based on the user logged in, or should it be based on session (sidebar will reset if the browser is closed)?

Step7750 commented 6 years ago

I think it should remember across browser startups. You could use the StorageService in https://github.com/MemePlace/Frontend/pull/46.

Step7750 commented 6 years ago

I'd recommend making a service such as SidebarService for this and let it store whether the sidebar is currently open, have an emitter to allow other components to subscribe to changes, and it can handle storing whether the bar should be open.

Dave0921 commented 6 years ago

I have the sidebar remembering whether it was opened/closed using emitters. However, I'm not sure on how to use Observables to subscribe to changes.