search

MemePlace / Frontend

Frontend Repo
3 stars 0 forks source link

Feature/meme dialog #57

Closed bandgeekdante closed 6 years ago

bandgeekdante commented 6 years ago

Please let me know what you think of the dialog sizing. We will want to keep the dialogs scrollable once we add comments, but maybe some memes are being blown up a bit too much? Also voting syncs properly between the dialog, card, and database, but there is a bug where switching between upvotes and downvotes causes visual issues (I think it's a problem in the backend; please see my posted issue there).

bandgeekdante commented 6 years ago

By the way, there's some spaces removed from import statements (like import { Component } versus import {Component}) which I didn't actually change manually, I think it's either WebStorm or ng lint that's fiddling with that.

Step7750 commented 6 years ago

If you resolve the conflicts with master, the diff will be easier to read.

bandgeekdante commented 6 years ago

I'm getting "TypeError: Cannot read property 'link' of undefined" after fixing all the merge conflicts and no images are loading (using up-to-date master branch for the Server)

bandgeekdante commented 6 years ago

bleh sorry a lot of the changes ended up being from ng lint (but I've stopped letting WebStorm change things on commits because that was just getting annoying)

Step7750 commented 6 years ago

Yeah, it's because the backend server changed so you'll need to delete your db.sqlite file and start a new

bandgeekdante commented 6 years ago

@Step7750 @xiningchen This branch should work properly now, and the dialog communicates directly to the meme service. Please review this when you can.

bandgeekdante commented 6 years ago

I'd like to start implementing comments but they would be part of the meme dialog so I either have to wait for this to be approved or build comments into this branch