fix #989: url escape issue and better url validation - Githubissues

Memmy-App / memmy

An Apollo inspired open-source iOS and Android client for Lemmy built with React-Native. Find us on the App Store and Google Play!

GNU Affero General Public License v3.0

547 stars 58 forks source link

fix #989: url escape issue and better url validation #1014

Open flx-sta opened 11 months ago

flx-sta commented 11 months ago

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

[x] You've discussed making your changes with a member of the dev team per contributing rules in the README
[x] Your changes are free of any lint errors
[x] Your changes are free of any typescript errors
[x] You've tested your changes

Summary

Fixes an issue with links not being opened properly. Adjust URL check to use new URL() with try catch instead of a regex pattern

Screenshots

https://github.com/Memmy-App/memmy/assets/50131232/c71c0c41-faf2-4456-81e5-3334b54bb741

Test Plan

Open the App
Go find a link with a special character (find one in the original issue #989)
open the link: It should open properly