Memmy-App / memmy

An Apollo inspired open-source iOS and Android client for Lemmy built with React-Native. Find us on the App Store and Google Play!
GNU Affero General Public License v3.0
547 stars 58 forks source link

[Bug]: When in your comments, tapping a comment no longer goes to it’s context thread #1019

Closed asciiletters closed 10 months ago

asciiletters commented 10 months ago

Check for open issues

Minimal reproducible example

Click the middle button can go to Comments. Tap a comment and nothing happens.

Expected Behavior

It should go to the comment in the context of the thread where it was submitted.

Version

Latest beta

App Store or TestFlight?

TestFlight

iOS Version

17.x Beta

Device

Latest iPhone

gkasdorf commented 10 months ago

To clarify this is happening on the inbox screen? I'm going to be taking a look at some issues tonight so I'll fix this.

Edit: Yea ok I see it. Thanks.

gkasdorf commented 10 months ago

Fixed somewhat, needs tweaking for deeply nested comments. Will work on this along with other issues. https://github.com/Memmy-App/memmy/commit/a600c895d03fe041ad4277dc9d22476948b5360b

asciiletters commented 10 months ago

Similar to this one, when you go to comments under inbox, tapping on those comments doesn’t work either. It just keeps loading and says undefined.

gkasdorf commented 10 months ago

Should be fixed now. Not going to close yet, as there are some things that need to get fixed still with it, but it is mostly functional.

asciiletters commented 10 months ago

When I tap a comment that someone made to me in my inbox now, it goes to the top of thread in question and not the the persons comment, so I can see what I said that they are responding to.

gkasdorf commented 10 months ago

Fixed.